Fix vision install for all files by tinglvv · Pull Request #9465 · pytorch/vision

tinglvv · 2026-04-02T19:01:59Z

2026-04-02T12:26:57.0297276Z C:/actions-runner/_work/_temp/conda_environment_23898900289/lib/site-packages/torch/include\c10/cuda/CUDACachingAllocator.h(105): error: invalid combination of type specifiers
2026-04-02T12:26:57.1656746Z     StreamSegmentSize(cudaStream_t s, bool char , size_t sz)
2026-04-02T12:26:57.2674865Z                                            ^
2026-04-02T12:26:57.4435273Z 
2026-04-02T12:26:57.5852644Z C:/actions-runner/_work/_temp/conda_environment_23898900289/lib/site-packages/torch/include\c10/cuda/CUDACachingAllocator.h(106): error: type name is not allowed
2026-04-02T12:26:57.7023246Z         : stream(s), is_small_pool(char ), total_size(sz) {}
2026-04-02T12:26:57.8187869Z                                    ^
2026-04-02T12:26:57.9261140Z 
2026-04-02T12:26:58.7092980Z 2 errors detected in the compilation of "C:/actions-runner/_work/vision/vision/pytorch/vision/torchvision/csrc/ops/cuda/nms_kernel.cu".

Previous fix #9464 only applies to the .cpp files compiled directly by cl.exe, not .cu files via nvcc. Need to change it in the setup.py.

cc @atalman

pytorch-bot · 2026-04-02T19:02:03Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9465

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit f88e169 with merge base 4e58149 ():

NEW FAILURES - The following jobs have failed:

Tests / unittests-linux (3.14, linux.12xlarge, cpu) / linux-job (gh)
RuntimeError: Command docker exec -t eecf665d91ffee022be6126b84d674a92e8f26930e3ce619d8df3f6094ad74d3 /exec failed with exit code 1
Tests / unittests-windows (3.14, windows.4xlarge, cpu) / windows-job (gh)
ModuleNotFoundError: No module named 'packaging.version'

This comment was automatically generated by Dr. CI and updates every 15 minutes.

atalman

lgtm

jovan2009 · 2026-04-04T16:13:33Z

2026-04-02T12:26:57.0297276Z C:/actions-runner/_work/_temp/conda_environment_23898900289/lib/site-packages/torch/include\c10/cuda/CUDACachingAllocator.h(105): error: invalid combination of type specifiers
2026-04-02T12:26:57.1656746Z     StreamSegmentSize(cudaStream_t s, bool char , size_t sz)
2026-04-02T12:26:57.2674865Z                                            ^
2026-04-02T12:26:57.4435273Z 
2026-04-02T12:26:57.5852644Z C:/actions-runner/_work/_temp/conda_environment_23898900289/lib/site-packages/torch/include\c10/cuda/CUDACachingAllocator.h(106): error: type name is not allowed
2026-04-02T12:26:57.7023246Z         : stream(s), is_small_pool(char ), total_size(sz) {}
2026-04-02T12:26:57.8187869Z                                    ^
2026-04-02T12:26:57.9261140Z 
2026-04-02T12:26:58.7092980Z 2 errors detected in the compilation of "C:/actions-runner/_work/vision/vision/pytorch/vision/torchvision/csrc/ops/cuda/nms_kernel.cu".

Previous fix #9464 only applies to the .cpp files compiled directly by cl.exe, not .cu files via nvcc. Need to change it in the setup.py.

cc @atalman

I encounter the same error, I reported it here: pytorch/pytorch#179005 . The issue seems to be with PyTorch itself. This PR pytorch/pytorch#179100 solves it for me, not only for TorchVision but also for when I try to build other projects.

atalman · 2026-04-06T14:27:29Z

HI @jovan2009 the issue is different now:

C:\actions-runner\_work\vision\vision>python pytorch/vision/test/smoke_test.py   || exit /b 1 
Traceback (most recent call last):
  File "C:\actions-runner\_work\vision\vision\pytorch\vision\test\smoke_test.py", line 8, in <module>
    import torch
  File "C:\actions-runner\_work\_temp\conda_environment_23955132613\lib\site-packages\torch\__init__.py", line 3029, in <module>
    import torch._native
  File "C:\actions-runner\_work\_temp\conda_environment_23955132613\lib\site-packages\torch\_native\__init__.py", line 8, in <module>
    from . import cutedsl_utils, ops, registry, triton_utils
  File "C:\actions-runner\_work\_temp\conda_environment_23955132613\lib\site-packages\torch\_native\cutedsl_utils.py", line 6, in <module>
    from packaging.version import Version
ModuleNotFoundError: No module named 'packaging'

jovan2009 · 2026-04-06T14:50:04Z

HI @jovan2009 the issue is different now:

C:\actions-runner\_work\vision\vision>python pytorch/vision/test/smoke_test.py   || exit /b 1 
Traceback (most recent call last):
  File "C:\actions-runner\_work\vision\vision\pytorch\vision\test\smoke_test.py", line 8, in <module>
    import torch
  File "C:\actions-runner\_work\_temp\conda_environment_23955132613\lib\site-packages\torch\__init__.py", line 3029, in <module>
    import torch._native
  File "C:\actions-runner\_work\_temp\conda_environment_23955132613\lib\site-packages\torch\_native\__init__.py", line 8, in <module>
    from . import cutedsl_utils, ops, registry, triton_utils
  File "C:\actions-runner\_work\_temp\conda_environment_23955132613\lib\site-packages\torch\_native\cutedsl_utils.py", line 6, in <module>
    from packaging.version import Version
ModuleNotFoundError: No module named 'packaging'

I think that is a completely different issue. Cuda 13.2 builds are still showing the same CUDACachingAllocator.h error:
https://github.com/pytorch/vision/actions/runs/24030647778/job/70078514526

https://github.com/pytorch/vision/actions/runs/23955132613/job/70051911372

My impression is that Cuda 13.2 builds are failing earlier, during building. All the others are failing a test after building successfully.

@atalman

tinglvv · 2026-04-06T20:57:44Z

Yes, the actual error that should be blocking is the CUDACachingAllocator.h(106): error: type name is not allowed. The other errors ModuleNotFoundError: No module named 'packaging' we have seen this before, I think it is infra issue.

tinglvv · 2026-04-07T18:44:52Z

Build still failing in https://github.com/pytorch/vision/actions/runs/23955132613/job/70243562557 since https://github.com/pytorch/pytorch/pull/179100/changes is not in nightly branch yet.

github-actions · 2026-04-08T18:25:29Z

Hey @atalman!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

ScottTodd · 2026-04-10T14:56:03Z

setup.py

+        if "nvcc" in extra_compile_args:
+            extra_compile_args["nvcc"].append("-Xcompiler")
+            extra_compile_args["nvcc"].append("/Zc:preprocessor")
+            extra_compile_args["nvcc"].append("-DCCCL_IGNORE_MSVC_TRADITIONAL_PREPROCESSOR_WARNING")


I suspect this broke Windows ROCm builds: ROCm/TheRock#4463 as soon as we picked up this commit from the 'nightly' branch of this repository (e51b6cc)

2026-04-10T08:02:02.3608593Z FAILED: [code=1] B:/src/vision/build/temp.win-amd64-cpython-313/Release/torchvision/csrc/ops/hip/ps_roi_align_kernel.obj 2026-04-10T08:02:02.3613939Z C:\home\runner\_work\_tool\Python\3.13.13\x64\Lib\site-packages\_rocm_sdk_devel\bin\hipcc.exe -std=c++20 -Xcompiler -D__HIP_PLATFORM_AMD__=1 -Xcompiler -DUSE_ROCM=1 -Xcompiler -DHIPBLAS_V2 -Xcompiler -fms-runtime-lib=dll -DWITH_HIP -Dtorchvision_EXPORTS -IB:\src\vision\torchvision\csrc -IC:\home\runner\_work\_tool\Python\3.13.13\x64\Lib\site-packages\torch\include -IC:\home\runner\_work\_tool\Python\3.13.13\x64\Lib\site-packages\torch\include\torch\csrc\api\include -IC:\home\runner\_work\_tool\Python\3.13.13\x64\Lib\site-packages\torch\include\THH -IC:\home\runner\_work\_tool\Python\3.13.13\x64\Lib\site-packages\_rocm_sdk_devel\include -IC:\home\runner\_work\_tool\Python\3.13.13\x64\include -IC:\home\runner\_work\_tool\Python\3.13.13\x64\Include -IC:\Program\Files\Microsoft\Visual\Studio\2022\Community\VC\Tools\MSVC\14.44.35207\include -IC:\Program\Files\Microsoft\Visual\Studio\2022\Community\VC\Tools\MSVC\14.44.35207\ATLMFC\include -IC:\Program\Files\Microsoft\Visual\Studio\2022\Community\VC\Auxiliary\VS\include -IC:\Program\Files\(x86)\Windows\Kits\10\include\10.0.26100.0\ucrt -IC:\Program\Files\(x86)\Windows\Kits\10\\include\10.0.26100.0\\um -IC:\Program\Files\(x86)\Windows\Kits\10\\include\10.0.26100.0\\shared -IC:\Program\Files\(x86)\Windows\Kits\10\\include\10.0.26100.0\\winrt -IC:\Program\Files\(x86)\Windows\Kits\10\\include\10.0.26100.0\\cppwinrt -IC:\Program\Files\(x86)\Windows\Kits\NETFXSDK\4.8\include\um -c B:\src\vision\torchvision\csrc\ops\hip\ps_roi_align_kernel.hip -o B:\src\vision\build\temp.win-amd64-cpython-313\Release\torchvision\csrc\ops\hip\ps_roi_align_kernel.obj -DCUDA_HAS_FP16=1 -D__HIP_NO_HALF_OPERATORS__=1 -D__HIP_NO_HALF_CONVERSIONS__=1 -DHIP_ENABLE_WARP_SYNC_BUILTINS=1 -fms-extensions -Wno-ignored-attributes -D__HIP_PLATFORM_AMD__=1 -DUSE_ROCM=1 -DHIPBLAS_V2 -fms-runtime-lib=dll -Xcompiler /Zc:preprocessor -DCCCL_IGNORE_MSVC_TRADITIONAL_PREPROCESSOR_WARNING -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=_C --offload-arch=gfx1030 --offload-arch=gfx1031 --offload-arch=gfx1032 --offload-arch=gfx1034 -fno-gpu-rdc 2026-04-10T08:02:02.3619214Z clang: error: no such file or directory: '/Zc:preprocessor'

Seems like we're swapping out nvcc for hipcc which does not understand the MSVC style flag?

meta-cla bot added the cla signed label Apr 2, 2026

fix the vision windows install script

7f9a788

tinglvv force-pushed the fix-vision-install branch from 4980a8f to 7f9a788 Compare April 2, 2026 19:06

tinglvv changed the title ~~Fix vision install~~ Fix vision install for all files Apr 2, 2026

atalman approved these changes Apr 2, 2026

View reviewed changes

tinglvv added 2 commits April 2, 2026 13:48

suppress the warning for cccl check

390c026

set for nvcc too

f88e169

This was referenced Apr 6, 2026

[BE][Win] Don't use small as argument name pytorch/pytorch#179100

Closed

Enable CUDA 13.2 binaries pytorch/pytorch#177067

Closed

atalman merged commit 6214cb2 into pytorch:main Apr 8, 2026
74 of 90 checks passed

ScottTodd mentioned this pull request Apr 10, 2026

[Issue] Windows PyTorch nightly wheel build fails: torchvision roi_align_kernel_hip.cpp compile breaks and setup.py bdist_wheel exits 1` ROCm/TheRock#4463

Open

ScottTodd reviewed Apr 10, 2026

View reviewed changes

astrelsky mentioned this pull request Apr 12, 2026

Fix windows builds with TheRock which doesn't accept "/Zc:preprocessor" TheRock#4463 #9475

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix vision install for all files#9465

Fix vision install for all files#9465
atalman merged 3 commits intopytorch:mainfrom
tinglvv:fix-vision-install

tinglvv commented Apr 2, 2026

Uh oh!

pytorch-bot bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

atalman left a comment

Uh oh!

jovan2009 commented Apr 4, 2026

Uh oh!

atalman commented Apr 6, 2026

Uh oh!

jovan2009 commented Apr 6, 2026 •

edited

Loading

Uh oh!

tinglvv commented Apr 6, 2026

Uh oh!

tinglvv commented Apr 7, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

ScottTodd Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tinglvv commented Apr 2, 2026

Uh oh!

pytorch-bot bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9465

❌ 2 New Failures

Uh oh!

atalman left a comment

Choose a reason for hiding this comment

Uh oh!

jovan2009 commented Apr 4, 2026

Uh oh!

atalman commented Apr 6, 2026

Uh oh!

jovan2009 commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tinglvv commented Apr 6, 2026

Uh oh!

tinglvv commented Apr 7, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

ScottTodd Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pytorch-bot bot commented Apr 2, 2026 •

edited

Loading

jovan2009 commented Apr 6, 2026 •

edited

Loading